dnishimura commented on a change in pull request #990: SAMZA-2161: Move
ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.
URL: https://github.com/apache/samza/pull/990#discussion_r274029181
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -287,18 +281,18 @@ private void onShutDown() {
inputStreamRegexMonitor.ifPresent(StreamRegexMonitor::stop);
systemAdmins.stop();
containerProcessManager.stop();
- coordinatorStreamManager.stop();
+ coordinatorStreamStore.close();
} catch (Throwable e) {
- log.error("Exception while stopping cluster based job coordinator", e);
+ LOG.error("Exception while stopping task manager {}", e);
}
- log.info("Stopped cluster based job coordinator");
+ LOG.info("Stopped task manager");
if (jmxServer != null) {
try {
jmxServer.stop();
- log.info("Stopped JMX server");
+ LOG.info("Stopped Jmx Server");
} catch (Throwable e) {
- log.error("Exception while stopping JMX server", e);
+ LOG.error("Exception while stopping jmx server {}", e);
Review comment:
See error logging comment above on line 255.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
