dnishimura commented on a change in pull request #990: SAMZA-2161: Move
ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.
URL: https://github.com/apache/samza/pull/990#discussion_r274037294
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -362,8 +356,8 @@ private void onShutDown() {
public void onInputStreamsChanged(Set<SystemStream> initialInputSet,
Set<SystemStream> newInputStreams,
Map<String, Pattern> regexesMonitored) {
if (hasDurableStores) {
- log.error("New input system-streams discovered. Failing the job
since it is stateful. " +
- "New input streams: {}, Existing input streams: {}",
newInputStreams, inputStreamsToMonitor);
+ LOG.error("New input system-streams discovered. Failing the job.
New input streams: {}", newInputStreams,
+ " Existing input streams:", inputStreamsToMonitor);
Review comment:
Logging here looks a little strange to me. I've never seen it done like
this. Does this work? The arguments don't appear to match the format params.
Pardon my ignorance if this is valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
