mynameborat commented on issue #1066: SAMZA-2235: Move the merging of side 
inputs with task inputs from the ExecutionPlanner to the JobModelManager
URL: https://github.com/apache/samza/pull/1066#issuecomment-499764127
 
 
   > @mynameborat Good point, but we can fix that in the rewriter by making it 
aware of systems for side inputs (and probably for changelogs too). Would that 
work?
   
   I think that would address the expansion problem. However, I also noticed 
couple of other scenarios that also relies on `task.inputs`.
   1. Partition count monitor
   2. Bootstrap and priorities streams uses it indirectly. Even with Ray's 
refactor, CSM restores side inputs using SystemConsumer which uses default 
chooser. 
   
   If we need to get this change without addressing the above, can we assess 
the priorities of these scenarios and create follow up tickets appropriately?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to