mynameborat commented on issue #1066: SAMZA-2235: Move the merging of side inputs with task inputs from the ExecutionPlanner to the JobModelManager URL: https://github.com/apache/samza/pull/1066#issuecomment-500056117 1. PartitionCountMonitor gets instantiated with the list of input streams to monitor. ClusterBasedJobCoordinator[1] and ZkJobCoordinator[2] are the ones that construct it and uses `task.inputs` to determine the input streams. We would regress on the feature that shuts down/restart the container in case of partition count change for side input streams. 2. Applications can specify priority and bootstrap properties for side inputs like every other stream. These configurations clubbed with `task.inputs` are used by chooser to determine bootstrap streams[3] and priority streams[4]. If application wants to specify priority across side inputs, it wouldn't be respected. [1] https://github.com/apache/samza/blob/8621db68b64f3d4f2c1a2aa986e3b1ea0dd80969/samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java#L321 [2] https://github.com/apache/samza/blob/8621db68b64f3d4f2c1a2aa986e3b1ea0dd80969/samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java#L369 [3] https://github.com/apache/samza/blob/8621db68b64f3d4f2c1a2aa986e3b1ea0dd80969/samza-core/src/main/java/org/apache/samza/config/DefaultChooserConfig.java#L54 [4]https://github.com/apache/samza/blob/8621db68b64f3d4f2c1a2aa986e3b1ea0dd80969/samza-core/src/main/java/org/apache/samza/config/DefaultChooserConfig.java#L73
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
