cameronlee314 commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage URL: https://github.com/apache/samza/pull/1126#discussion_r311160409
########## File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsManager.java ########## @@ -80,20 +82,20 @@ private final SystemStream diagnosticSystemStream; public DiagnosticsManager(String jobName, String jobId, Map<String, ContainerModel> containerModels, Review comment: For a constructor with this many args and a good chance for needing to add more, consider expanding to one line per argument. Then additions in the future will be easier to read, and it will be easier to keep the line lengths short. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
