cameronlee314 commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage URL: https://github.com/apache/samza/pull/1126#discussion_r311277419
########## File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsManager.java ########## @@ -93,10 +105,22 @@ public DiagnosticsManager(String jobName, String jobId, Map<String, ContainerMod } @VisibleForTesting - DiagnosticsManager(String jobName, String jobId, Map<String, ContainerModel> containerModels, - int containerMemoryMb, int containerNumCores, int numStoresWithChangelog, Long maxHeapSizeBytes, Integer containerThreadPoolSize, - String containerId, String executionEnvContainerId, String taskClassVersion, String samzaVersion, String hostname, - SystemStream diagnosticSystemStream, SystemProducer systemProducer, Duration terminationDuration, + DiagnosticsManager(String jobName, + String jobId, + Map<String, ContainerModel> containerModels, + int containerMemoryMb, + int containerNumCores, + int numStoresWithChangelog, + Long maxHeapSizeBytes, Review comment: Can these be primitives too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
