cameronlee314 commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage URL: https://github.com/apache/samza/pull/1126#discussion_r311159423
########## File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsManager.java ########## @@ -68,6 +68,8 @@ private final Integer containerMemoryMb; private final Integer containerNumCores; private final Integer numStoresWithChangelog; + private final long maxHeapSizeBytes; + private final Integer containerThreadPoolSize; Review comment: Is this nullable? If not, please use primitive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
