rmatharu commented on a change in pull request #1227: SAMZA-2404: Container
Placement Handler for dispatching container placement messages between
metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r352770462
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -185,18 +196,22 @@ public ContainerProcessManager(Config config,
SamzaApplicationState state, Metri
() -> new ContainerAllocator(this.clusterResourceManager,
clusterManagerConfig, state,
hostAffinityEnabled, this.containerManager));
this.allocatorThread = new Thread(this.containerAllocator, "Container
Allocator Thread");
+ this.containerPlacementHandler = new
ContainerPlacementHandler(metadataStore, this,
clusterManagerConfig.getClusterManagerContainerPlacementHandlerSleepMs());
+ this.containerPlacementHandlerThread = new
Thread(containerPlacementHandler, "Container Placement Handler Thread");
LOG.info("Finished container process manager initialization");
}
public boolean shouldShutdown() {
- LOG.debug("ContainerProcessManager state: Completed containers: {},
Configured containers: {}, Are there too many failed containers: {}, Is
allocator thread alive: {}",
- state.completedProcessors.get(), state.processorCount,
jobFailureCriteriaMet ? "yes" : "no", allocatorThread.isAlive() ? "yes" : "no");
+ LOG.debug(
Review comment:
Maybe this should be LOG.info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
