rmatharu commented on a change in pull request #1227: SAMZA-2404: Container 
Placement Handler for dispatching container placement messages between 
metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r355807705
 
 

 ##########
 File path: 
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
 ##########
 @@ -97,6 +100,8 @@
 
   // The ContainerManager manages control actions for both active & standby 
containers
   private final ContainerManager containerManager;
+  private ContainerPlacementHandler containerPlacementHandler;
+  private Thread containerPlacementHandlerThread;
 
 Review comment:
   Maybe we can use the 
   ```afterExecute(Runnable r, Throwable t)``` method of ExecutorService?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to