rmatharu commented on a change in pull request #1227: SAMZA-2404: Container Placement Handler for dispatching container placement messages between metastore and JobCoordinator URL: https://github.com/apache/samza/pull/1227#discussion_r352778839
########## File path: samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java ########## @@ -113,6 +113,12 @@ public static final String CLUSTER_MANAGER_SLEEP_MS = "cluster-manager.jobcoordinator.sleep.interval.ms"; private static final int DEFAULT_CLUSTER_MANAGER_SLEEP_MS = 1000; + /** + * The container placement handler sleeps for a configurable time before checking for now ContainerPlacement messages + */ + public static final String CLUSTER_MANAGER_CONTAINER_PLACEMENT_HANDLER_SLEEP_MS = "cluster-manager.container-placement-handler.sleep.interval.ms"; + private static final int DEFAULT_CLUSTER_MANAGER_CONTAINER_PLACEMENT_HANDLER_SLEEP_MS = 5000; Review comment: Do we expect different jobs to tune this timeout differently? If not, i'd suggest removing this config ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
