cameronlee314 commented on a change in pull request #1238: SAMZA-2407: Add
job.config.loader.* configs in JobConfig & corresponding env variables in
ShellCommandConfig
URL: https://github.com/apache/samza/pull/1238#discussion_r362947973
##########
File path:
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
##########
@@ -25,6 +25,11 @@ object ShellCommandConfig {
*/
val ENV_COORDINATOR_SYSTEM_CONFIG = "SAMZA_COORDINATOR_SYSTEM_CONFIG"
+ /**
+ * This enviorment variable is used to pass configs provided during job
submission.
Review comment:
1. s/enviorment/environment
2. Is this a JSON serialized map like `ENV_COORDINATOR_SYSTEM_CONFIG`? If
so, could you please specify that in the javadoc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
