cameronlee314 commented on a change in pull request #1238: SAMZA-2407: Add
job.config.loader.* configs in JobConfig & corresponding env variables in
ShellCommandConfig
URL: https://github.com/apache/samza/pull/1238#discussion_r363895586
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -195,20 +205,20 @@ public int getMonitorPartitionChangeFrequency() {
public Map<String, Pattern> getMonitorRegexPatternMap(String rewritersList) {
Map<String, Pattern> inputRegexesToMonitor = new HashMap<>();
Stream.of(rewritersList.split(",")).forEach(rewriterName -> {
- Optional<String> rewriterSystem = getRegexResolvedSystem(rewriterName);
- Optional<String> rewriterRegex = getRegexResolvedStreams(rewriterName);
- if (rewriterSystem.isPresent() && rewriterRegex.isPresent()) {
- Pattern newPatternForSystem;
- Pattern existingPatternForSystem =
inputRegexesToMonitor.get(rewriterSystem.get());
- if (existingPatternForSystem == null) {
- newPatternForSystem = Pattern.compile(rewriterRegex.get());
- } else {
- newPatternForSystem =
- Pattern.compile(String.join("|",
existingPatternForSystem.pattern(), rewriterRegex.get()));
- }
- inputRegexesToMonitor.put(rewriterSystem.get(), newPatternForSystem);
+ Optional<String> rewriterSystem = getRegexResolvedSystem(rewriterName);
+ Optional<String> rewriterRegex = getRegexResolvedStreams(rewriterName);
+ if (rewriterSystem.isPresent() && rewriterRegex.isPresent()) {
+ Pattern newPatternForSystem;
+ Pattern existingPatternForSystem =
inputRegexesToMonitor.get(rewriterSystem.get());
+ if (existingPatternForSystem == null) {
+ newPatternForSystem = Pattern.compile(rewriterRegex.get());
+ } else {
+ newPatternForSystem =
+ Pattern.compile(String.join("|",
existingPatternForSystem.pattern(), rewriterRegex.get()));
}
- });
+ inputRegexesToMonitor.put(rewriterSystem.get(), newPatternForSystem);
+ }
+ });
Review comment:
Is this an indentation change only? If so, can you please undo it so your
diff is just your changes?
Your name would go into the commit history for changing this piece of code,
so it would be good to avoid that given that your change is unrelated to
cleaning up indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
