cameronlee314 commented on a change in pull request #1238: SAMZA-2407: Add
job.config.loader.* configs in JobConfig & corresponding env variables in
ShellCommandConfig
URL: https://github.com/apache/samza/pull/1238#discussion_r363896518
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -348,4 +358,11 @@ public String getCoordinatorStreamFactory() {
return get(COORDINATOR_STREAM_FACTORY,
DEFAULT_COORDINATOR_STREAM_CONFIG_FACTORY);
}
+ /**
+ * Get config loader factory according to the configs
+ * @return full qualified name of {@link ConfigLoaderFactory}
+ */
+ public String getConfigLoaderFactory() {
+ return get(CONFIG_LOADER_FACTORY);
Review comment:
Is this an optional config, or is it required? If it is optional, can you
please have it return `Optional<String>`, or add a default value? If required,
can you please throw a `ConfigException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
