bkonold commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r366617839
##########
File path:
samza-core/src/test/java/org/apache/samza/runtime/TestRemoteApplicationRunner.java
##########
@@ -75,9 +75,20 @@ public void testWaitForFinishTimesout() {
assertFalse("Application finished before the timeout.", finished);
}
+ @Test
+ public void testRunWithConfigLoaderFactoryPresent() {
Review comment:
Hmm. I guess the code as-is isn't very unit test friendly. It would be nice
to test the invocation of .submit vs .run on JobRunner depending on the
presence of the ConfigLoaderFactory.
Maybe we could factor out the JobRunner creation into its own method, and
use a spy to stub out the return value of that method to be a mock JobRunner
that we can verify? Disclaimer though, I'm not sure what the best practices are
of using spies...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
