bkonold commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r366646602
##########
File path:
samza-core/src/test/java/org/apache/samza/runtime/TestRemoteApplicationRunner.java
##########
@@ -75,9 +75,20 @@ public void testWaitForFinishTimesout() {
assertFalse("Application finished before the timeout.", finished);
}
+ @Test
+ public void testRunWithConfigLoaderFactoryPresent() {
Review comment:
There is some precedence elsewhere in samza code;
ZkJobCoordinator.readJobModelFromMetadataStore for example uses a similar
method structure + spy in unit test.
You are correct that the test written now does ensure that the legacy flow
isn't triggered, but it does little to verify the behavior of the new flow. I
won't block the PR on this though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
