kw2542 commented on a change in pull request #1247: SAMZA-2408: Update
RemoteApplicationRunner to submit job only
URL: https://github.com/apache/samza/pull/1247#discussion_r366624080
##########
File path:
samza-core/src/test/java/org/apache/samza/runtime/TestRemoteApplicationRunner.java
##########
@@ -75,9 +75,20 @@ public void testWaitForFinishTimesout() {
assertFalse("Application finished before the timeout.", finished);
}
+ @Test
+ public void testRunWithConfigLoaderFactoryPresent() {
Review comment:
Haha, I figured that too. In general, I prefer not to mess with production
code for the sake of unit tests.
The current unit actually test the new flow, I passed null SamzaApplication
to RemoteApplicationRunner's constructor. In RemoteApplicationRunner#run, if it
goes the legacy flow, it will throw exception when constructing
RemoteJobPlanner where SamzaApplication is required. Do you think this is
enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
