kw2542 opened a new pull request #1256: SAMZA-2420: Update CommandLine to use config loader for local config file URL: https://github.com/apache/samza/pull/1256 Design: https://cwiki.apache.org/confluence/display/SAMZA/SEP-23%3A+Simplify+Job+Runner Changes: 1. Update CommandLine to use config loader instead of config factory 2. Removed common.properties and adds its values to each job config 3. Update CheckpointTool to read new offsets from local file only. API Changes: 1. Add config-loader-factory and config-loader-properties in CommandLine to support specifying ConfigLoaderFactory and its properties needed to load config. 2. Remove config-factory and config-path in CommandLine to discountinue the usage of ConfigFactory 3. Update CheckpointTool to read new offsets from local file only. Upgrade Instructions: All usages in CommandLine and its subclasses will switch from --config-factory & --config-path to --config-loader-factory & --config-loader-properties, including job launch. Usage Instructions For example, --config-factory=org.apache.samza.config.factories.PropertiesConfigFactory --config-path=file:///location/file.txt will be changed to --config-loader-factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory --config-loader-properties path=file:///location/file.txt Tests 1. Unit tests 2. Test against Hello Samza example with deploy/samza/bin/run-app.sh --config-loader-factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory --config-loader-properties path=$PWD/deploy/samza/config/wikipedia-feed.properties
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
