cameronlee314 commented on a change in pull request #1256: SAMZA-2420: Update
CommandLine to use config loader for local config file
URL: https://github.com/apache/samza/pull/1256#discussion_r371571656
##########
File path:
samza-test/src/main/java/org/apache/samza/test/integration/LocalApplicationRunnerMain.java
##########
@@ -53,14 +53,14 @@ public static void main(String[] args) throws Exception {
try {
LOGGER.info("Launching stream application: {} to run.", app);
- runner.run(buildExternalContext(config).orElse(null));
+ runner.run(buildExternalContext().orElse(null));
runner.waitForFinish();
} catch (Exception e) {
LOGGER.error("Exception occurred when running application: {}.", app, e);
}
}
- private static Optional<ExternalContext> buildExternalContext(Config config)
{
+ private static Optional<ExternalContext> buildExternalContext() {
Review comment:
The intention to have the "unused" `config` was so that a custom fork could
use the `config` if necessary (see comment inside `buildExternalContext`. Could
we please keep the `config`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
