kw2542 commented on a change in pull request #1256: SAMZA-2420: Update CommandLine to use config loader for local config file URL: https://github.com/apache/samza/pull/1256#discussion_r369876444
########## File path: samza-test/src/main/config/join/joiner.samza ########## @@ -16,6 +16,33 @@ # specific language governing permissions and limitations # under the License. +#################### +### UPDATE THIS! ### Review comment: These unit tests are reading two files, common.properties and joiner.samza, as the input config, after updating to use ConfigLoader, we do not want to read from multiple files anymore, so I am deleting common.properties file and move all its properties in each job config file instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
