cameronlee314 commented on a change in pull request #1256: SAMZA-2420: Update
CommandLine to use config loader for local config file
URL: https://github.com/apache/samza/pull/1256#discussion_r371565933
##########
File path:
samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java
##########
@@ -158,6 +155,7 @@ private void getContainerModels() {
* Get the changelog streams and the storage factories from the config file
* and put them into the maps
*/
+ @SuppressWarnings("unchecked")
Review comment:
Instead of doing a blanket suppress for the whole method, could you please
consider doing a suppression for the single line that needs to be suppressed?
Then, if someone accidentally makes a change which should not be suppressed,
then there will still be a warning for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
