cameronlee314 commented on a change in pull request #1266: Adding internal
autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r374852769
##########
File path:
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
##########
@@ -154,8 +161,15 @@ public int getNumCores() {
}
}
+ /**
+ * Return the value of CLUSTER_MANAGER_MEMORY_MB or CONTAINER_MAX_MEMORY_MB
(in that order) if autosizing is not enabled,
+ * otherwise returns the value of JOB_AUTOSIZING_CONTAINER_MEMORY_MB.
+ * @return
+ */
public int getContainerMemoryMb() {
- if (containsKey(CLUSTER_MANAGER_MEMORY_MB)) {
+ if (getBoolean(JobConfig.JOB_AUTOSIZING_ENABLED, false) &&
containsKey(JobConfig.JOB_AUTOSIZING_CONTAINER_MEMORY_MB)) {
Review comment:
Same about using `getAutosizingEnabled`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
