cameronlee314 commented on a change in pull request #1266: Adding internal
autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r374854085
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -165,9 +174,18 @@ public String getCoordinatorSystemNameOrNull() {
return Optional.ofNullable(get(JOB_DEFAULT_SYSTEM));
}
+ /**
+ * Return the value of JOB_CONTAINER_COUNT or "yarn.container.count" (in
that order) if autosizing is not enabled,
+ * otherwise returns the value of JOB_AUTOSIZING_CONTAINER_COUNT.
+ * @return
+ */
public int getContainerCount() {
+ Optional<String> autoscalingContainerCountValue =
Optional.ofNullable(get(JOB_AUTOSIZING_CONTAINER_COUNT));
Review comment:
Could you please use `autosizing` instead of `autoscaling` to keep
terminology consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
