cameronlee314 commented on a change in pull request #1266: Adding internal
autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r374873923
##########
File path:
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
##########
@@ -116,7 +116,25 @@ object ShellCommandConfig {
class ShellCommandConfig(config: Config) extends ScalaMapConfig(config) {
def getCommand =
getOption(ShellCommandConfig.COMMAND_SHELL_EXECUTE).getOrElse("bin/run-container.sh")
- def getTaskOpts = getOption(ShellCommandConfig.TASK_JVM_OPTS)
+ def getTaskOpts = {
+ var jvmOpts = getOption(ShellCommandConfig.TASK_JVM_OPTS)
+ val jobConfig = new JobConfig(config)
+
+ if (jobConfig.getAutosizingEnabled &&
getOption(JobConfig.JOB_AUTOSIZING_CONTAINER_MAX_HEAP_MB).isDefined) {
Review comment:
Could you please add a unit test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
