cameronlee314 commented on a change in pull request #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386753381
##########
File path: build.gradle
##########
@@ -866,3 +866,8 @@ project(":samza-test_$scalaSuffix") {
from(configurations.archives.artifacts.files) { into("lib/") }
}
}
+
+// SAMZA-2473 read wrapper version from gradle.properties
+wrapper {
+ gradleVersion = project.gradleVersion
Review comment:
Could you please add a comment in `gradle.properties` right above
`gradleVersion` to re-run `./gradlew wrapper` and commit the generated changes
when upgrading Gradle in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services