DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion
and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r387192032
##########
File path: gradle/maven.gradle
##########
@@ -22,13 +22,13 @@ subprojects {
publishing {
publications {
mavenJava(MavenPublication) {
- from components.java
- if(project.name == 'samza-shell') {
- artifact shellTarGz {
- classifier "dist"
Review comment:
Verification details.
Before (master branch at 851fc48):
```
$ ./gradlew clean :samza-shell:assemble
$ ls -al samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
-rw-r--r-- 1 kmoore eng 96811 Mar 3 09:48
samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
$ shasum samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
40acd2debccda136a7dee1a2647eb29ddb88df04
samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
```
After (PR branch):
```
$ ./gradlew clean :samza-shell:assemble
$ ls -al samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
-rw-r--r-- 1 kmoore eng 96811 Mar 3 09:50
samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
$ shasum samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
40acd2debccda136a7dee1a2647eb29ddb88df04
samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
```
Checksums are identical and filenames match, including classifier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
