DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion 
and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386769659
 
 

 ##########
 File path: gradle/maven.gradle
 ##########
 @@ -22,13 +22,13 @@ subprojects {
   publishing {
     publications {
       mavenJava(MavenPublication) {
-        from components.java
-        if(project.name == 'samza-shell') {
-          artifact shellTarGz {
-            classifier "dist"
 
 Review comment:
   The artifact produced by task `shellTarGz` already specifies the `dist` 
classifier: https://github.com/apache/samza/blob/master/build.gradle#L552
   
   Just in case, I'll build again and verify locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to