bkonold commented on a change in pull request #1343:
URL: https://github.com/apache/samza/pull/1343#discussion_r417001181
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -625,7 +625,9 @@ public void run() {
log.trace("Update offset for ssp {}, offset {}",
envelope.getSystemStreamPartition(), envelope.getOffset());
// update offset
- task.offsetManager().update(task.taskName(),
envelope.getSystemStreamPartition(), envelope.getOffset());
+ if (task.offsetManager() != null) {
Review comment:
Good point. A default construction of OffsetManager should do fine here.
To be clear, we won't actually be doing anything useful with OffsetManager
when it comes to side inputs, but we can eliminate this check by having
offsetManger in RunLoopTask default to 'new OffsetManager'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
