bkonold commented on a change in pull request #1343: URL: https://github.com/apache/samza/pull/1343#discussion_r417009813
########## File path: samza-core/src/main/scala/org/apache/samza/storage/SideInputRestoreTask.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.storage; + +import java.nio.file.Path; +import java.util.Map; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.samza.checkpoint.CheckpointId; +import org.apache.samza.container.RunLoopTask; +import org.apache.samza.container.TaskInstanceMetrics; +import org.apache.samza.container.TaskName; +import org.apache.samza.system.IncomingMessageEnvelope; +import org.apache.samza.system.SystemStreamPartition; +import org.apache.samza.task.ReadableCoordinator; +import org.apache.samza.task.TaskCallbackFactory; +import scala.collection.JavaConversions; + + +class SideInputRestoreTask extends RunLoopTask { + + private final TaskName taskName; + private final Set<SystemStreamPartition> taskSSPs; + private final TaskSideInputHandler taskSideInputHandler; + private final TaskSideInputStorageManager taskSideInputStorageManager; + private final TaskInstanceMetrics metrics; + + public SideInputRestoreTask( + TaskName taskName, + Set<SystemStreamPartition> taskSSPs, + TaskSideInputHandler taskSideInputHandler, + TaskSideInputStorageManager taskSideInputStorageManager, + TaskInstanceMetrics metrics) { + this.taskName = taskName; + this.taskSSPs = taskSSPs; + this.taskSideInputHandler = taskSideInputHandler; + this.taskSideInputStorageManager = taskSideInputStorageManager; + this.metrics = metrics; Review comment: 1. I had this here mostly since it was required for refactor but did not realize that TaskInstance does per task commit / process metric recording as well. We should here too. 2. Yes, ContainerStorageManager will pass the same instances of SamzaContainerMetrics and TaskInstanceMetrics as are used already in the main RunLoop. This will conflate the definitions of those metrics to include side inputs, which may be an undesirable change. Let's chat about this in more detail. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
