bkonold commented on a change in pull request #1343:
URL: https://github.com/apache/samza/pull/1343#discussion_r417010749
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -110,13 +114,13 @@
public class ContainerStorageManager {
private static final Logger LOG =
LoggerFactory.getLogger(ContainerStorageManager.class);
private static final String RESTORE_THREAD_NAME = "Samza Restore Thread-%d";
- private static final String SIDEINPUTS_READ_THREAD_NAME = "SideInputs Read
Thread";
- private static final String SIDEINPUTS_FLUSH_THREAD_NAME = "SideInputs Flush
Thread";
+ private static final String SIDEINPUTS_RUNLOOP_THREAD_NAME = "SideInputs
RunLoop Thread";
+ private static final String SIDEINPUTS_CHECKPOINT_THREAD_NAME = "SideInputs
Checkpoint Refresh Thread";
private static final String SIDEINPUTS_METRICS_PREFIX = "side-inputs-";
// We use a prefix to differentiate the SystemConsumersMetrics for
sideInputs from the ones in SamzaContainer
private static final int SIDE_INPUT_READ_THREAD_TIMEOUT_SECONDS = 10; //
Timeout with which sideinput read thread checks for exceptions
- private static final Duration SIDE_INPUT_FLUSH_TIMEOUT =
Duration.ofMinutes(1); // Period with which sideinputs are flushed
+ private static final Duration SIDE_INPUT_CHECKPOINT_SHUTDOWN_TIMEOUT =
Duration.ofMinutes(1); // Period with which sideinputs are flushed
Review comment:
This is the shutdown timeout for the executor that is doing polling of
new checkpoints.
The name can maybe be more clear, and I'll clean up the outdated comment.
`SIDE_INPUT_CHECKPOINT_POLL_EXECUTOR_TIMEOUT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
