rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463858926
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala
##########
@@ -148,7 +149,7 @@ class MetricsSnapshotReporter(
// publish to Kafka only if the metricsMsg carries any metrics
if (!metricsMsg.isEmpty) {
- val header = new MetricsHeader(jobName, jobId, containerName,
execEnvironmentContainerId, source, version, samzaVersion, host, clock(),
resetTime)
+ val header = new MetricsHeader(jobName, jobId, containerName,
execEnvironmentContainerId, source, version, samzaVersion, host, clock(),
resetTime, config)
Review comment:
see comment above.
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
##########
@@ -124,7 +124,9 @@ class MetricsSnapshotReporterFactory extends
MetricsReporterFactory with Logging
Util.getTaskClassVersion(config),
Util.getSamzaVersion,
Util.getLocalHost.getHostName,
- serde, blacklist)
+ serde,
+ blacklist,
+ config)
Review comment:
remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
