abhishekshivanna commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463877183
##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -70,7 +70,7 @@ public static void writeMetadataFile(String jobName, String
jobId, String contai
MetricsHeader metricsHeader =
new MetricsHeader(jobName, jobId, "samza-container-" + containerId,
execEnvContainerId.orElse(""),
LocalContainerRunner.class.getName(),
Util.getTaskClassVersion(config), Util.getSamzaVersion(),
- Util.getLocalHost().getHostName(), System.currentTimeMillis(),
System.currentTimeMillis());
+ Util.getLocalHost().getHostName(), System.currentTimeMillis(),
System.currentTimeMillis(), config);
Review comment:
+1 I agree we should only pick the fields we are interested in. I
suggest we create a versioned model (JSON serializable) that holds the fields
we are interested in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
