rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463860833



##########
File path: 
samza-core/src/test/java/org/apache/samza/diagnostics/TestDiagnosticsManager.java
##########
@@ -59,6 +62,7 @@
   private int numPersistentStores = 2;
   private int containerNumCores = 2;
   private boolean autosizingEnabled = false;
+  private Config config = new MapConfig(ImmutableMap.of("job.name", jobName, 
"job.id", jobId));

Review comment:
       Please add additional configs to make it somewhat representative of the 
configs that we want to emit. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to