rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463898362
##########
File path:
samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java
##########
@@ -155,6 +158,14 @@ public void
addProcessorStopEvents(List<ProcessorStopEvent> stopEventList) {
}
}
+ /**
+ * Add the job's config to the message.
+ * @param config the config to add.
+ */
+ public void addConfig(Config config) {
+ addToMetricsMessage(GROUP_NAME_FOR_DIAGNOSTICS_MANAGER, CONFIG, config);
Review comment:
config is a non-primitive object, cast to Map<String, String> here
before serializing and adding into the map; similar to how containerModels are
added above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
