rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463898578
##########
File path:
samza-core/src/test/java/org/apache/samza/diagnostics/TestDiagnosticsManager.java
##########
@@ -272,6 +278,7 @@ private void
validateOutgoingMessageEnvelope(OutgoingMessageEnvelope outgoingMes
Assert.assertEquals(containerNumCores,
diagnosticsStreamMessage.getContainerNumCores().intValue());
Assert.assertEquals(numPersistentStores,
diagnosticsStreamMessage.getNumPersistentStores().intValue());
Assert.assertEquals(autosizingEnabled,
diagnosticsStreamMessage.getAutosizingEnabled());
+ Assert.assertEquals(config, diagnosticsStreamMessage.getConfig());
Review comment:
Config does not define an equals method, so not sure how this test is
working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
