rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463898479
##########
File path:
samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java
##########
@@ -228,6 +239,14 @@ public Boolean getAutosizingEnabled() {
return (Boolean) getFromMetricsMessage(GROUP_NAME_FOR_DIAGNOSTICS_MANAGER,
AUTOSIZING_ENABLED_METRIC_NAME);
}
+ /**
+ * This method gets the config of the job from the MetricsMessage.
+ * @return the config of the job.
+ */
+ public Config getConfig() {
+ return (Config) getFromMetricsMessage(GROUP_NAME_FOR_DIAGNOSTICS_MANAGER,
CONFIG);
Review comment:
Since we will serialize as Map<String, String>
getFromMetricsMessage will return a Map<String, String>
that needs to be converted to Config like this:
new MapConfig(getFromMetricsMessage(GROUP_NAME_FOR_DIAGNOSTICS_MANAGER,
CONFIG));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
