mynameborat commented on a change in pull request #1421:
URL: https://github.com/apache/samza/pull/1421#discussion_r475019596
##########
File path:
samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
##########
@@ -466,11 +464,6 @@ class JobModelManager(
debug("Stopping HTTP server.")
server.stop
info("Stopped HTTP server.")
- if (localityManager != null) {
- info("Stopping localityManager")
- localityManager.close()
Review comment:
Good catch. It doesn't do much inside close as the metadata store used
within gets closed inside job coordinator. For completeness, i moved this to
job coordinator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
