Sanil15 commented on a change in pull request #1421:
URL: https://github.com/apache/samza/pull/1421#discussion_r476625264
##########
File path:
samza-yarn/src/main/java/org/apache/samza/validation/YarnJobValidationTool.java
##########
@@ -158,23 +159,24 @@ public void validateJmxMetrics() throws Exception {
CoordinatorStreamStore coordinatorStreamStore = new
CoordinatorStreamStore(config, metricsRegistry);
coordinatorStreamStore.init();
try {
- Config configFromCoordinatorStream =
CoordinatorStreamUtil.readConfigFromCoordinatorStream(coordinatorStreamStore);
- ChangelogStreamManager changelogStreamManager = new
ChangelogStreamManager(coordinatorStreamStore);
- JobModelManager jobModelManager =
- JobModelManager.apply(configFromCoordinatorStream,
changelogStreamManager.readPartitionMapping(),
- coordinatorStreamStore, metricsRegistry);
+ LocalityManager localityManager =
+ new LocalityManager(new
NamespaceAwareCoordinatorStreamStore(coordinatorStreamStore, SetConfig.TYPE));
validator.init(config);
- Map<String, String> jmxUrls =
jobModelManager.jobModel().getAllContainerToHostValues(SetContainerHostMapping.JMX_TUNNELING_URL_KEY);
- for (Map.Entry<String, String> entry : jmxUrls.entrySet()) {
- String containerId = entry.getKey();
- String jmxUrl = entry.getValue();
- log.info("validate container " + containerId + " metrics with JMX: " +
jmxUrl);
- JmxMetricsAccessor jmxMetrics = new JmxMetricsAccessor(jmxUrl);
- jmxMetrics.connect();
- validator.validate(jmxMetrics);
- jmxMetrics.close();
- log.info("validate container " + containerId + " successfully");
+ LocalityModel localityModel = localityManager.readLocality();
+
+ for (ContainerLocality containerLocality :
localityModel.getContainerLocalities().values()) {
+ String containerId = containerLocality.id();
+ String jmxUrl = containerLocality.jmxTunnelingUrl();
+ if (StringUtils.isNotBlank(jmxUrl)) {
Review comment:
In samza we control JMX enable disable with a config, you should only
emit JMX metrics here if that config is enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
