mynameborat commented on a change in pull request #1421:
URL: https://github.com/apache/samza/pull/1421#discussion_r476718374
##########
File path:
samza-core/src/main/java/org/apache/samza/container/LocalityManager.java
##########
@@ -53,28 +56,26 @@ public LocalityManager(MetadataStore metadataStore) {
}
/**
- * Method to allow read container locality information from the {@link
MetadataStore}.
- * This method is used in {@link
org.apache.samza.coordinator.JobModelManager}.
+ * Fetch the container locality information from the {@link MetadataStore}.
*
- * @return the map of containerId: (hostname)
+ * @return the {@code LocalityModel} for the job
*/
- public Map<String, Map<String, String>> readContainerLocality() {
Review comment:
we got rid of this code and the new method returns a model. We will need
a method to return the locality of all containers or specific container & we
already have a method to expose both.
Exposing helper methods within each attributes of `ContainerLocality` like
`host` or `jmx` seems too redundant up top here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
