mynameborat commented on a change in pull request #1421:
URL: https://github.com/apache/samza/pull/1421#discussion_r476913697
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -174,6 +176,7 @@
private final MetadataStore metadataStore;
private final SystemAdmins systemAdmins;
+ private final LocalityManager localityManager;
Review comment:
In the first pass, I didn't have a local instance for locality manager
but ended up introducing one to manage the lifecycle along with the other
components.
What do you think about doing it as part of the consolidation refactor work?
We currently have `ContainerPlacementMetadataStore` in job coordinator. when we
move that within CM, we can also move locality manager all in on go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
