perkss commented on a change in pull request #1464:
URL: https://github.com/apache/samza/pull/1464#discussion_r581740149
##########
File path:
samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
##########
@@ -165,7 +165,7 @@ public void testDeserializeUnknownTaskModelField() throws
IOException {
/**
* Given a {@link ContainerModel} JSON with neither a processor-id nor a
container-id, deserialization should fail.
*/
- @Test(expected = SamzaException.class)
Review comment:
I do agree this seemed a bit icky, will try and work around it.
Basically they are wrapping exceptions in Jackson as standard practice to add
further context to the exception. The code that does this is nested here
[MapDeserializer](https://github.com/FasterXML/jackson-databind/blob/jackson-databind-2.12.1/src/main/java/com/fasterxml/jackson/databind/deser/std/MapDeserializer.java#L621)
which calls
[ContainerDeserializerBase](https://github.com/FasterXML/jackson-databind/blob/jackson-databind-2.12.1/src/main/java/com/fasterxml/jackson/databind/deser/std/ContainerDeserializerBase.java#L173)
The originator of this exception is here in Samza and states it is for 0.13
and 0.14 support is this throw still required?
[reference](https://github.com/apache/samza/blob/master/samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java#L109)
Will continue to look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
