kw2542 commented on a change in pull request #1464:
URL: https://github.com/apache/samza/pull/1464#discussion_r583039805



##########
File path: 
samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
##########
@@ -165,7 +165,7 @@ public void testDeserializeUnknownTaskModelField() throws 
IOException {
   /**
    * Given a {@link ContainerModel} JSON with neither a processor-id nor a 
container-id, deserialization should fail.
    */
-  @Test(expected = SamzaException.class)

Review comment:
       Good point, I don't think we have to stick with SamzaException and it 
won't be necessary to wrap JsonProcessingException in SamzaException again. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to