perkss commented on a change in pull request #1464:
URL: https://github.com/apache/samza/pull/1464#discussion_r583835787
##########
File path:
samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
##########
@@ -165,7 +165,7 @@ public void testDeserializeUnknownTaskModelField() throws
IOException {
/**
* Given a {@link ContainerModel} JSON with neither a processor-id nor a
container-id, deserialization should fail.
*/
- @Test(expected = SamzaException.class)
Review comment:
If we did want to achieve this to remain as was I raised an
[issue](https://github.com/FasterXML/jackson-databind/issues/3068) in Jackson
that stopped the
[WRAP_EXCEPTION](https://fasterxml.github.io/jackson-databind/javadoc/2.12/com/fasterxml/jackson/databind/DeserializationFeature.html#WRAP_EXCEPTIONS)
feature from working. With this disabled and tested against the SNAPSHOT it
worked as originally. So we could wait for 2.12.2 to come out and it would
behave the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
