ajothomas commented on a change in pull request #1560:
URL: https://github.com/apache/samza/pull/1560#discussion_r761578873
##########
File path:
samza-core/src/main/java/org/apache/samza/table/batching/CompactBatch.java
##########
@@ -68,8 +71,10 @@ public int size() {
if (operation instanceof GetOperation) {
queries.putIfAbsent(operation.getKey(), operation);
+ } else if (operation instanceof UpdateOperation) {
+ throw new BatchingNotSupportedException("Batching not supported for
Updates with CompactBatches");
Review comment:
This exception is typically caught in the `updateAsync` method when
batching fails and standard `updateAsync` method is called.
```
try {
return batchProcessor.processPutDeleteOrUpdateOperations(new
UpdateOperation<>(key, update, args));
} catch (BatchingNotSupportedException e) {
return table.updateAsync(key, update, args);
} catch (Exception e) {
throw new SamzaException(e);
}
```
##########
File path:
samza-core/src/main/java/org/apache/samza/table/batching/UpdateOperation.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.samza.table.batching;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * Update operation.
+ *
+ * @param <K> The type of the key.
+ * @param <U> The type of the update
+ */
+public class UpdateOperation<K, V, U> implements Operation<K, V, U> {
+ final private K key;
+ final private U val;
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
