ajothomas commented on a change in pull request #1560:
URL: https://github.com/apache/samza/pull/1560#discussion_r763263015
##########
File path:
samza-core/src/main/java/org/apache/samza/table/batching/CompactBatch.java
##########
@@ -68,8 +71,10 @@ public int size() {
if (operation instanceof GetOperation) {
queries.putIfAbsent(operation.getKey(), operation);
+ } else if (operation instanceof UpdateOperation) {
+ throw new BatchingNotSupportedException("Batching not supported for
Updates with CompactBatches");
Review comment:
Right, that makes sense. It should be possible to do it within the
constructor of `SendUpdateToTableOperatorImpl`. The only way to do that is to
expose the `BatchProvider` from the `RemoteTable` and check if it is an
instance of `CompactBatchProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
