xinyuiscool commented on a change in pull request #1560: URL: https://github.com/apache/samza/pull/1560#discussion_r762346311
########## File path: samza-api/src/main/java/org/apache/samza/table/RecordDoesNotExistException.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.table; + +/** + * Custom exception which can be thrown by implementations of {@link org.apache.samza.table.remote.TableWriteFunction} + * when {@link AsyncReadWriteTable#updateAsync(Object, Object, Object...)} fails due an existing record not being + * present for the given key. {@link org.apache.samza.operators.MessageStream#sendUpdateTo(Table, Object...)} will + * attempt to call {@link AsyncReadWriteTable#putAsync(Object, Object, Object...)} instead to insert a new record if a + * default is provided. + */ +public class RecordDoesNotExistException extends RuntimeException { Review comment: Is it possible to add a test to test out the use case when this exception happens? It will assure we will do the put first with default value then post again. ########## File path: samza-core/src/main/java/org/apache/samza/table/batching/CompactBatch.java ########## @@ -68,8 +71,10 @@ public int size() { if (operation instanceof GetOperation) { queries.putIfAbsent(operation.getKey(), operation); + } else if (operation instanceof UpdateOperation) { + throw new BatchingNotSupportedException("Batching not supported for Updates with CompactBatches"); Review comment: Oh, what I meant is that if we don't support update with certain table mode, like here batching with compaction, we should catch it during the pipeline building stage, instead of running stage. So I think we can add a check in SendUpdateToTableOperatorImpl or somewhere when input.sendUpdateToTable() is used (the high-level api). There we validate the compact batching is not turned on. That way the user will see the exception before running the pipeline. ########## File path: samza-api/src/main/java/org/apache/samza/table/RecordDoesNotExistException.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.table; + +/** + * Custom exception which can be thrown by implementations of {@link org.apache.samza.table.remote.TableWriteFunction} + * when {@link AsyncReadWriteTable#updateAsync(Object, Object, Object...)} fails due an existing record not being + * present for the given key. {@link org.apache.samza.operators.MessageStream#sendUpdateTo(Table, Object...)} will + * attempt to call {@link AsyncReadWriteTable#putAsync(Object, Object, Object...)} instead to insert a new record if a + * default is provided. + */ +public class RecordDoesNotExistException extends RuntimeException { Review comment: Let's name is RecordNotFoundException, seems it's common that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
