mynameborat commented on a change in pull request #1576:
URL: https://github.com/apache/samza/pull/1576#discussion_r789239499
##########
File path:
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartition.java
##########
@@ -38,6 +39,7 @@ public SystemStreamPartition(String system, String stream,
Partition partition)
super(system, stream);
this.partition = partition;
this.hash = computeHashCode();
+ this.keyBucket = -1;
Review comment:
why not default the keyBucket to just 0 or 1 however you are basing the
bucket index? Cut shorts all the additional handling of -1 and so-on and also
logically makes sense that in the event of keyBucket < 1 there is one bucket to
which all the of the messages belonging to the task is assigned to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
