lakshmi-manasa-g commented on a change in pull request #1576:
URL: https://github.com/apache/samza/pull/1576#discussion_r797181750
##########
File path:
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartition.java
##########
@@ -38,6 +39,7 @@ public SystemStreamPartition(String system, String stream,
Partition partition)
super(system, stream);
this.partition = partition;
this.hash = computeHashCode();
+ this.keyBucket = -1;
Review comment:
during the second pr https://github.com/apache/samza/pull/1580 dev, i
realized that there is a bigger problem with having keyBucket=0 in the
ssp.tostring when elasticity is not enabled.
GroupBySystemStreamPartition uses ssp.tostring as the taksName and task
level metrics (like sends etc) use the task name. keeping keyBucket=0 in all
ssp.tostring even when elasticity is not enabled will result in loss of metrics
history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
