mynameborat commented on a change in pull request #1576:
URL: https://github.com/apache/samza/pull/1576#discussion_r798890172



##########
File path: 
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartition.java
##########
@@ -38,6 +39,7 @@ public SystemStreamPartition(String system, String stream, 
Partition partition)
     super(system, stream);
     this.partition = partition;
     this.hash = computeHashCode();
+    this.keyBucket = -1;

Review comment:
       How exactly is this doable? is your bucket based on 1-index is it? when 
you have elasticity enabled, one of the bucket will have 0 as the index and 
hence its representation would be different from others.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to