jia-gao commented on PR #1631: URL: https://github.com/apache/samza/pull/1631#issuecomment-1252600397
> lets please follow https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines for all samza PR descriptions > > We also need to explain that for open source samza, the partition count is 1 for diagnostics stream due to DiagnosticsUtil.createDiagnosticsStream which relies on default parttition count within stream spec which is set to 1. hence this change will not break anything for open source community and is backwards compatible. However, it allows for better distrubution if the diag topic's partition count is increased and some info on how null partition key helps for the most commonly used system aka kafka. Thanks, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
