lakshmi-manasa-g commented on PR #1631: URL: https://github.com/apache/samza/pull/1631#issuecomment-1254380649
> Is the partition key field not used as part of the emitted payload in downstream? That does seem like a backward incompatible change given the messages produced going forward wouldn't have the hostname exposed as key of the message? partition key field is used to determine which partition of the diagnostics stream to send the message to right. partition key is not part of the payload itself the payload for these messages is MetricsSnapshotSerdeV2().toBytes(diagnosticsStreamMessage.convertToMetricsSnapshot. the most commonly used diagnostics system aka kafka for uses partition key for routing the msg key (which is null here) and msg value (which is the metrics snapshot) pair to the appropriate partition. partition key does not become the msg key right, msg key is explicitly set to null here. given that diagnostic stream is created with 1 partition count by default, this change will be backwards compatible right. did you mean the case where partition count is set to larger than 1 then this is not backwards compatible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
